[PATCH] D48218: [Power9] Add remaining __flaot128 builtin support for FMA round to odd

[Lei Huang via Phabricator via llvm-commits]

lei added inline comments.


================
Comment at: lib/Target/PowerPC/PPCInstrVSX.td:2488
+  def XSMSUBQPO : X_VT5_VA5_VB5_FMA_Ro<63, 420, "xsmsubqpo" ,
+                                      [(set f128:$vT,
+                                      (int_ppc_fmaf128_round_to_odd
----------------
indentation for these patterns are wrong.


================
Comment at: lib/Target/PowerPC/PPCInstrVSX.td:2496
+  def XSNMADDQPO: X_VT5_VA5_VB5_FMA_Ro<63, 452, "xsnmaddqpo",
+                                      [(set f128:$vT,
+                                      (fneg (int_ppc_fmaf128_round_to_odd
----------------
Same issue with indentation.  See `XSNMADDQP` for reference.


================
Comment at: test/CodeGen/PowerPC/builtins-ppc-p9-f128.ll:51
 ; CHECK-LABEL: testFMAOdd
-; CHECK: xsmaddqpo
+; CHECK-DAG: xsmaddqpo
+; CHECK-DAG: xsmsubqpo
----------------
Might be good to actually have the registers stated here to ensure we are acting on the proper values.


https://reviews.llvm.org/D48218