[PATCH] D47540: [lld] Enable Visual Studio compatible output

Chris Jackson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 26 02:09:45 PDT 2018


chrisjackson added a comment.

In https://reviews.llvm.org/D47540#1141831, @ruiu wrote:

> I created a program that doesn't link and tried to build it on VS. Linker error messages in the VS window are not clickable -- I couldn't jump to the location by clicking a filename and a linename (e.g. foo\bar\baz.cpp:42) in the linker error message. Is this expected?


@ruiu

Thanks for looking at this. Can you please clarify your experiment e.g. did you use lld in VS or the MSVC linker?
The format of the source  "foo\bar\baz.cpp:42" does not meet compatibility for VS diagnostic hyperlinks. There should be no colon and the line and column information should be paranthesized, but you'll see that from my comments and changes.
Thanks,

Chris


https://reviews.llvm.org/D47540





More information about the llvm-commits mailing list