[PATCH] D48587: [llvm-exegesis] Get the BenchmarkRunner from the ExegesisTarget.

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 26 01:47:29 PDT 2018


gchatelet accepted this revision.
gchatelet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: tools/llvm-exegesis/llvm-exegesis.cpp:54
+                                "Uop Decomposition"),
+                     clEnumValN(exegesis::InstructionBenchmark::Unknown,
+                                "analysis", "Analysis")));
----------------
courbet wrote:
> gchatelet wrote:
> > Unknown is Analysis?
> Yes, that allows getting rid of the extra enum and avoid a switch to convert from one enum to the other. 
Ok so please add a comment explaining why Analysis is different from latency/uops.


Repository:
  rL LLVM

https://reviews.llvm.org/D48587





More information about the llvm-commits mailing list