[compiler-rt] r335519 - [CMake] Run libFuzzer tests with check-all.

[via llvm-commits]

Hi Matt,

Our internal bot started to fail after your commit because we build with -Werror and two warnings from the googletest framework are causing it to fail.

FAILED: cd /home/siadmin/jenkins/w/opensource/opensource_build/build/projects/compiler-rt/lib/fuzzer/tests && /home/siadmin/jenkins/w/opensource/opensource_build/build/./bin/clang -fPIC -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -std=c++11 -Wno-unknown-warning-option -DGTEST_NO_LLVM_RAW_OSTREAM=1 -DGTEST_HAS_RTTI=0 -I/home/siadmin/jenkins/w/opensource/opensource_build/llvm/utils/unittest/googletest/include -I/home/siadmin/jenkins/w/opensource/opensource_build/llvm/utils/unittest/googletest -I/home/siadmin/jenkins/w/opensource/opensource_build/llvm/projects/compiler-rt/lib/fuzzer -fno-rtti -Werror -O2 -m64 -c -o FuzzerTestObjects.gtest-all.cc.x86_64.o /home/siadmin/jenkins/w/opensource/opensource_build/llvm/utils/unittest/googletest/src/gtest-all.cc
In file included from /home/siadmin/jenkins/w/opensource/opensource_build/llvm/utils/unittest/googletest/src/gtest-all.cc:42:
/home/siadmin/jenkins/w/opensource/opensource_build/llvm/utils/unittest/googletest/src/gtest.cc:2842:5: error: default label in switch which covers all enumeration values [-Werror,-Wcovered-switch-default]
    default:
    ^
In file included from /home/siadmin/jenkins/w/opensource/opensource_build/llvm/utils/unittest/googletest/src/gtest-all.cc:43:
/home/siadmin/jenkins/w/opensource/opensource_build/llvm/utils/unittest/googletest/src/gtest-death-test.cc:581:5: error: default label in switch which covers all enumeration values [-Werror,-Wcovered-switch-default]
    default:
    ^
2 errors generated.

Can you take a look? I think the fix would be to specify that -Werror is not used when building your tests. For example, in the same build that failed, I see identical warnings from building sanitizer tests that do not get promoted to an error.

Douglas Yung

> -----Original Message-----
> From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On
> Behalf Of Matt Morehouse via llvm-commits
> Sent: Monday, June 25, 2018 13:30
> To: llvm-commits at lists.llvm.org
> Subject: [compiler-rt] r335519 - [CMake] Run libFuzzer tests with
> check-all.
> 
> Author: morehouse
> Date: Mon Jun 25 13:30:03 2018
> New Revision: 335519
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=335519&view=rev
> Log:
> [CMake] Run libFuzzer tests with check-all.
> 
> Reviewers: kcc
> 
> Reviewed By: kcc
> 
> Subscribers: llvm-commits, mgorny
> 
> Differential Revision: https://reviews.llvm.org/D48200
> 
> Modified:
>     compiler-rt/trunk/test/fuzzer/CMakeLists.txt
> 
> Modified: compiler-rt/trunk/test/fuzzer/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/compiler-
> rt/trunk/test/fuzzer/CMakeLists.txt?rev=335519&r1=335518&r2=335519&view
> =diff
> =======================================================================
> =======
> --- compiler-rt/trunk/test/fuzzer/CMakeLists.txt (original)
> +++ compiler-rt/trunk/test/fuzzer/CMakeLists.txt Mon Jun 25 13:30:03
> 2018
> @@ -11,8 +11,6 @@ if(COMPILER_RT_INCLUDE_TESTS)
>    list(APPEND LIBFUZZER_TEST_DEPS FuzzerUnitTests)
>  endif()
> 
> -set(EXCLUDE_FROM_ALL ON)
> -
>  add_custom_target(check-fuzzer)
> 
>  if(COMPILER_RT_INCLUDE_TESTS)
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits