[PATCH] D46365: AMDGPU: Separate R600 and GCN TableGen files
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 26 00:45:37 PDT 2018
arsenm added inline comments.
================
Comment at: lib/Target/AMDGPU/AMDGPUFeatures.td:1
+
+def FeatureFP64 : SubtargetFeature<"fp64",
----------------
Missing header comment
================
Comment at: lib/Target/AMDGPU/AMDGPUSubtarget.h:479-481
+ virtual bool hasBORROW() const {
+ return true;
}
----------------
Why are these leftover as virtual?
================
Comment at: lib/Target/AMDGPU/R600.td:1
+
+include "llvm/Target/Target.td"
----------------
Missing header comment
Repository:
rL LLVM
https://reviews.llvm.org/D46365
More information about the llvm-commits
mailing list