[PATCH] D48584: [InstCombine] Delay foldICmpUsingKnownBits until simple transforms are done
Max Kazantsev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 26 00:19:58 PDT 2018
mkazantsev added a comment.
In https://reviews.llvm.org/D48584#1143240, @lebedev.ri wrote:
> This only moves the `foldICmpUsingKnownBits()` call later on,
> but in PR37636 <https://bugs.llvm.org/show_bug.cgi?id=37636#c4> @spatel suggests it *might* expose more problems.
> Does this expose any problems?
>From my point of view, no. We use different predicates in some cases, I am not convinced that either of them is better (at least less/greater predicates are more useful for SCEV analysis than ne/eq).
I'll fix the comments.
https://reviews.llvm.org/D48584
More information about the llvm-commits
mailing list