[PATCH] D48405: [ELF] Assign RF_EXEC rank even if --no-rosegment or SECTIONS command is used

Mon Jun 25 23:59:53 PDT 2018

grimar accepted this revision.
grimar added a comment.

LGTM with 2 nits.

================
Comment at: test/ELF/arm-exidx-order.s:1
+// REQUIRES: arm
 // RUN: llvm-mc -filetype=obj -triple=armv7a-none-linux-gnueabi %s -o %t
----------------
One more place to commit separately.

================
Comment at: test/ELF/linkerscript/non-absolute.s:8

+# 0x94+6 - 169 = B = -0xf
 # DUMP:       Disassembly of section .text:
----------------
The calculation is now correct, but I am not sure how it is useful.

What is -0xF here? How is it correlated with the output which is 0xFFFFFFFFFFFFFFF1?
Since there was no such comment originally, I would either remove it or fix so that it becomes useful.

Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D48405