[PATCH] D48584: [InstCombine] Delay foldICmpUsingKnownBits until simple transforms are done

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 25 23:20:39 PDT 2018


lebedev.ri added inline comments.


================
Comment at: test/Transforms/InstCombine/icmp_sdiv_with_and_without_range.ll:4-5
+
+target datalayout = "e-i64:64-f80:128-n8:16:32:64"
+target triple = "x86_64-unknown-linux-gnu"
+
----------------
Could you add comment what this tests, and commit as-is [and rebase this]?
Also, i'm not sure these two lines are needed.


https://reviews.llvm.org/D48584





More information about the llvm-commits mailing list