[PATCH] D48542: [llvm-exegesis] Generate snippet setup code.

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: llvm/trunk/unittests/tools/llvm-exegesis/X86/TargetTest.cpp:40
+  const auto Insts = Target_->setRegToConstant(llvm::X86::XMM1);
+  EXPECT_THAT(Insts, SizeIs(Gt(0)));
 }
----------------
pcc wrote:
> Looks like this line has caused a build warning:
> ```
> utils/unittest/googlemock/include/gmock/gmock-matchers.h:216:60: warning: comparison of integers of different signs: 'const unsigned long' and 'const int' [-Wsign-compare]
>   bool operator()(const A& a, const B& b) const { return a > b; }
>                                                          ~ ^ ~
> [...]
> unittests/tools/llvm-exegesis/X86/TargetTest.cpp:40:3: note: in instantiation of function template specialization 'testing::internal::PredicateFormatterFromMatcher<testing::internal::SizeIsMatcher<testing::internal::GtMatcher<int> > >::operator()<std::vector<llvm::MCInst, std::allocator<llvm::MCInst> > >' requested here
>   EXPECT_THAT(Insts, SizeIs(Gt(0)));
>   ^
> ```
Sorry about that. This was fixed in r335547.


Repository:
  rL LLVM

https://reviews.llvm.org/D48542