[llvm] r335579 - [InstCombine] (A + 1) + (B ^ -1) --> A - B
Gil Rapaport via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 25 22:31:18 PDT 2018
Author: gilr
Date: Mon Jun 25 22:31:18 2018
New Revision: 335579
URL: http://llvm.org/viewvc/llvm-project?rev=335579&view=rev
Log:
[InstCombine] (A + 1) + (B ^ -1) --> A - B
Turn canonicalized subtraction back into (-1 - B) and combine it with (A + 1) into (A - B).
This is similar to the folding already done for (B ^ -1) + Const into (-1 + Const) - B.
Differential Revision: https://reviews.llvm.org/D48535
Modified:
llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp
llvm/trunk/test/Transforms/InstCombine/add.ll
Modified: llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp?rev=335579&r1=335578&r2=335579&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp (original)
+++ llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp Mon Jun 25 22:31:18 2018
@@ -1212,6 +1212,11 @@ Instruction *InstCombiner::visitAdd(Bina
if (Value *V = checkForNegativeOperand(I, Builder))
return replaceInstUsesWith(I, V);
+ // (A + 1) + ~B --> A - B
+ // ~B + (A + 1) --> A - B
+ if (match(&I, m_c_BinOp(m_Add(m_Value(A), m_One()), m_Not(m_Value(B)))))
+ return BinaryOperator::CreateSub(A, B);
+
// X % C0 + (( X / C0 ) % C1) * C0 => X % (C0 * C1)
if (Value *V = SimplifyAddWithRemainder(I)) return replaceInstUsesWith(I, V);
Modified: llvm/trunk/test/Transforms/InstCombine/add.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/add.ll?rev=335579&r1=335578&r2=335579&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/InstCombine/add.ll (original)
+++ llvm/trunk/test/Transforms/InstCombine/add.ll Mon Jun 25 22:31:18 2018
@@ -802,3 +802,40 @@ final:
%value = add <2 x i32> <i32 123, i32 333>, %A
ret <2 x i32> %value
}
+
+; E = (A + 1) + ~B = A - B
+define i32 @add_not_increment(i32 %A, i32 %B) {
+; CHECK-LABEL: @add_not_increment(
+; CHECK-NEXT: [[E:%.*]] = sub i32 %A, %B
+; CHECK-NEXT: ret i32 [[E]]
+;
+ %C = xor i32 %B, -1
+ %D = add i32 %A, 1
+ %E = add i32 %D, %C
+ ret i32 %E
+}
+
+; E = (A + 1) + ~B = A - B
+define <2 x i32> @add_not_increment_vec(<2 x i32> %A, <2 x i32> %B) {
+; CHECK-LABEL: @add_not_increment_vec(
+; CHECK-NEXT: [[E:%.*]] = sub <2 x i32> %A, %B
+; CHECK-NEXT: ret <2 x i32> [[E]]
+;
+ %C = xor <2 x i32> %B, <i32 -1, i32 -1>
+ %D = add <2 x i32> %A, <i32 1, i32 1>
+ %E = add <2 x i32> %D, %C
+ ret <2 x i32> %E
+}
+
+; E = ~B + (1 + A) = A - B
+define i32 @add_not_increment_commuted(i32 %A, i32 %B) {
+; CHECK-LABEL: @add_not_increment_commuted(
+; CHECK-NEXT: [[E:%.*]] = sub i32 %A, %B
+; CHECK-NEXT: ret i32 [[E]]
+;
+ %C = xor i32 %B, -1
+ %D = add i32 %A, 1
+ %E = add i32 %C, %D
+ ret i32 %E
+}
+
More information about the llvm-commits
mailing list