[PATCH] D48567: [COFF] Fix constant sharing regression for MinGW

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: include/llvm/CodeGen/TargetLoweringObjectFileImpl.h:137
 
+  Triple TT;
+
----------------
I'd prefer it if we didn't put this here, but instead put something in MCAsmInfo, like the existing `HasCOFFAssociativeComdats`.


================
Comment at: lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1354-1356
+  if (!TT.isKnownWindowsMSVCEnvironment() &&
+      !TT.isWindowsItaniumEnvironment() &&
+      !TT.isWindowsCoreCLREnvironment())
----------------
It'd be nicer to spell this as a positive check for a gnu or cygwin environment.


Repository:
  rL LLVM

https://reviews.llvm.org/D48567