[compiler-rt] r335523 - [ubsan] Mark a test case as unsupported on Windows

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 25 13:56:23 PDT 2018


Author: vedantk
Date: Mon Jun 25 13:56:23 2018
New Revision: 335523

URL: http://llvm.org/viewvc/llvm-project?rev=335523&view=rev
Log:
[ubsan] Mark a test case as unsupported on Windows

__ubsan_on_report isn't defined as weak, and redefining it in a test is
not supported on Windows.

See the error message here: https://reviews.llvm.org/D48446

Modified:
    compiler-rt/trunk/test/ubsan/TestCases/Misc/monitor.cpp

Modified: compiler-rt/trunk/test/ubsan/TestCases/Misc/monitor.cpp
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/TestCases/Misc/monitor.cpp?rev=335523&r1=335522&r2=335523&view=diff
==============================================================================
--- compiler-rt/trunk/test/ubsan/TestCases/Misc/monitor.cpp (original)
+++ compiler-rt/trunk/test/ubsan/TestCases/Misc/monitor.cpp Mon Jun 25 13:56:23 2018
@@ -1,6 +1,11 @@
 // RUN: %clangxx -w -fsanitize=bool %s -o %t
 // RUN: %run %t 2>&1 | FileCheck %s
 
+// __ubsan_on_report is not defined as weak. Redefining it here isn't supported
+// on Windows.
+//
+// UNSUPPORTED: win32
+
 #include <iostream>
 
 extern "C" {
@@ -10,8 +15,8 @@ void __ubsan_get_current_report_data(con
                                      unsigned *OutLine, unsigned *OutCol,
                                      char **OutMemoryAddr);
 
-// Override the weak definition of __ubsan_on_report from the runtime, just
-// for testing purposes.
+// Override the definition of __ubsan_on_report from the runtime, just for
+// testing purposes.
 void __ubsan_on_report(void) {
   const char *IssueKind, *Message, *Filename;
   unsigned Line, Col;




More information about the llvm-commits mailing list