[PATCH] D37644: [CMake][runtimes] Use variables rather than ":" delimiters
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 25 12:55:21 PDT 2018
phosek marked 2 inline comments as done.
phosek added inline comments.
================
Comment at: runtimes/CMakeLists.txt:432
set(target ${name})
string(REPLACE ":" ";" target_list ${target})
list(GET target_list 0 name)
----------------
phosek wrote:
> beanz wrote:
> > phosek wrote:
> > > There's one other use case of ":" which is used in cache files, I'm not sure if we should replace that one as well?
> > Ideally I think we probably should replace it. In general I don't like treating `:` as special characters.
> I'll do this in a separate patch since it'll require more changes.
Done in D48061.
Repository:
rL LLVM
https://reviews.llvm.org/D37644
More information about the llvm-commits
mailing list