[PATCH] D48528: [UBsan] Enable ubsan minimal unit tests on OpenBSD

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: cmake/Modules/SanitizerUtils.cmake:84
 # Add target to check code style for sanitizer runtimes.
-if(CMAKE_HOST_UNIX)
+if(CMAKE_HOST_UNIX AND NOT OS_NAME MATCHES "OpenBSD")
   add_custom_target(SanitizerLintCheck
----------------
devnexen wrote:
> vitalybuka wrote:
> > Why? It just needs a python.
> The scripts can t works not because of Python.
How hard would it be to fix it? Can you share output?


================
Comment at: test/ubsan_minimal/lit.common.cfg:26
+if config.host_os == 'OpenBSD':
+  clang_ubsan_cflags.append("-fuse-ld=lld")
+  clang_ubsan_cxxflags.append("-fuse-ld=lld")
----------------
devnexen wrote:
> vitalybuka wrote:
> > krytarowski wrote:
> > > vitalybuka wrote:
> > > > Why is OpenBSD special here?
> > > I guess that it uses OpenBSD's gplv2 gnu ld that is incompatible with the modern world.
> > Should it use lld by default, from driver?
> I thought about too indeed.
If you are not planing to do so soon, could you please comment TODO here, so we can remove it when we don't need it.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D48528