[PATCH] D48540: [LLDB] Select helper sign comparison fix

David CARLIER via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 25 09:15:14 PDT 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rL335489: [LLDB] Select helper sign comparison fix (authored by devnexen, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D48540?vs=152652&id=152706#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D48540

Files:
  lldb/trunk/source/Utility/SelectHelper.cpp


Index: lldb/trunk/source/Utility/SelectHelper.cpp
===================================================================
--- lldb/trunk/source/Utility/SelectHelper.cpp
+++ lldb/trunk/source/Utility/SelectHelper.cpp
@@ -109,8 +109,8 @@
     pair.second.PrepareForSelect();
     const lldb::socket_t fd = pair.first;
 #if !defined(__APPLE__) && !defined(_MSC_VER)
-    lldbassert(fd < FD_SETSIZE);
-    if (fd >= FD_SETSIZE) {
+    lldbassert(fd < static_cast<int>(FD_SETSIZE));
+    if (fd >= static_cast<int>(FD_SETSIZE)) {
       error.SetErrorStringWithFormat("%i is too large for select()", fd);
       return error;
     }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48540.152706.patch
Type: text/x-patch
Size: 624 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180625/3e8551d6/attachment.bin>


More information about the llvm-commits mailing list