[PATCH] D48547: Improve ConvertDebugDeclareToDebugValue

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: include/llvm/IR/Instructions.h:103
+  /// e.g. in case of a VLA.
+  uint64_t getAllocationSizeInBits(const DataLayout &DL) const;
+
----------------
We generally try to move away from special values. Would it make sense to return an Optional<uint64_t> here?


================
Comment at: test/Transforms/Mem2Reg/debug-alloca-vla-1.ll:3
+
+; ModuleID = 'debug-alloca-vla.ll'
+target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
----------------
Can you add a comment explaining what is being tested here?


================
Comment at: test/Transforms/Mem2Reg/debug-alloca-vla-2.ll:20
+; CHECK: %t0 = add i32 %[[PHI]], 1
+; CHECK: call void @llvm.dbg.value(metadata i32 undef,
+; CHECK-SAME:                      metadata !DIExpression())
----------------
and here?


Repository:
  rL LLVM

https://reviews.llvm.org/D48547