[PATCH] D48372: [MemorySSAUpdater] Remove deleted trivial Phis from active workset

[Alexandros Lamprineas via Phabricator via llvm-commits]

labrinea added a comment.





================
Comment at: lib/Analysis/MemorySSAUpdater.cpp:304
     // Put any new phis on the fixup list, and process them
     FixupList.append(InsertedPHIs.end() - StartingPHISize, InsertedPHIs.end());
   }
----------------
> https://reviews.llvm.org/D48504 is a (almost) drop-in replacement for SetVector, with a constant time remove().
@efriedma  thanks a lot for your effort on this :)

It seems we need a random access iterator here:

```
FixupList.append(InsertedPHIs.at(StartingPHISize), InsertedPHIs.end());
```
otherwise the following assertion fails

```
static_assert(IsRandomAccess, "The '-' operator is only defined for random access iterators.");
```


https://reviews.llvm.org/D48372