[PATCH] D48502: Fix direct calls to __wrap_sym when it is relocated

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 24 22:58:51 PDT 2018


ruiu added inline comments.


================
Comment at: ELF/SymbolTable.cpp:213-214
+  for (WrappedSymbol &W : WrappedSymbols) {
+    memcpy(W.Wrap, W.Sym, sizeof(SymbolUnion));
+
+    // Keep this so that this copy of the symbol remains dropped
----------------
This seems a bit hacky to me, as it always overwrites W.Wrap even though we wrote some data to W.Wrap before in another function. Can you remove that code to initialize W.Wrap?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D48502





More information about the llvm-commits mailing list