[PATCH] D48472: [ELF] Change isSectionData to exclude SHF_EXECINSTR

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 22 14:57:08 PDT 2018


jyknight accepted this revision.
jyknight added a comment.
This revision is now accepted and ready to land.

I guess it's better...I mean, seems reasonable, I guess.

But I'd really *much* rather see the *actual* type information from the object file, not invent arbitrary classifications. E.g., how about we just print PROGBITS, NOBITS, etc.

And it'd be nice to see all the other section attributes too (flags/info/link/etc), for that matter...


Repository:
  rL LLVM

https://reviews.llvm.org/D48472





More information about the llvm-commits mailing list