[llvm] r335392 - [llvm-mca] Remove unnecessary include and forward decl in RCU. NFC.
Matt Davis via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 22 14:35:26 PDT 2018
Author: mattd
Date: Fri Jun 22 14:35:26 2018
New Revision: 335392
URL: http://llvm.org/viewvc/llvm-project?rev=335392&view=rev
Log:
[llvm-mca] Remove unnecessary include and forward decl in RCU. NFC.
The DispatchUnit is no longer a dependency of RCU, so this patch removes a
stale include and forward decl. This patch also cleans up some comments.
Modified:
llvm/trunk/tools/llvm-mca/RetireControlUnit.cpp
llvm/trunk/tools/llvm-mca/RetireControlUnit.h
Modified: llvm/trunk/tools/llvm-mca/RetireControlUnit.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/RetireControlUnit.cpp?rev=335392&r1=335391&r2=335392&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-mca/RetireControlUnit.cpp (original)
+++ llvm/trunk/tools/llvm-mca/RetireControlUnit.cpp Fri Jun 22 14:35:26 2018
@@ -13,7 +13,6 @@
//===----------------------------------------------------------------------===//
#include "RetireControlUnit.h"
-#include "DispatchStage.h"
#include "llvm/Support/Debug.h"
using namespace llvm;
Modified: llvm/trunk/tools/llvm-mca/RetireControlUnit.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/RetireControlUnit.h?rev=335392&r1=335391&r2=335392&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-mca/RetireControlUnit.h (original)
+++ llvm/trunk/tools/llvm-mca/RetireControlUnit.h Fri Jun 22 14:35:26 2018
@@ -23,15 +23,14 @@
namespace mca {
-class DispatchStage;
-
/// This class tracks which instructions are in-flight (i.e., dispatched but not
/// retired) in the OoO backend.
//
/// This class checks on every cycle if/which instructions can be retired.
/// Instructions are retired in program order.
-/// In the event of instruction retired, the DispatchStage object that owns
+/// In the event of an instruction being retired, the pipeline that owns
/// this RetireControlUnit (RCU) gets notified.
+///
/// On instruction retired, register updates are all architecturally
/// committed, and any temporary registers originally allocated for the
/// retired instruction are freed.
@@ -39,7 +38,7 @@ struct RetireControlUnit {
// A RUToken is created by the RCU for every instruction dispatched to the
// schedulers. These "tokens" are managed by the RCU in its token Queue.
//
- // On evey cycle ('cycleEvent'), the RCU iterates through the token queue
+ // On every cycle ('cycleEvent'), the RCU iterates through the token queue
// looking for any token with its 'Executed' flag set. If a token has that
// flag set, then the instruction has reached the write-back stage and will
// be retired by the RCU.
More information about the llvm-commits
mailing list