[PATCH] D48402: [mingw] Fix GCC ABI compatibility for comdat things

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

In https://reviews.llvm.org/D48402#1141048, @pirama wrote:

> In https://reviews.llvm.org/D48402#1140046, @rnk wrote:
>
> > In https://reviews.llvm.org/D48402#1140019, @pirama wrote:
> >
> > > Sections:
> > >  ....
> > >
> > >   3 .text$___Z3fooi 00000013  00000000  00000000  0000012c  2**4
> > >                  CONTENTS, ALLOC, LOAD, RELOC, READONLY, CODE, LINK_ONCE_DISCARD
> > >
> > >   Could that explain the difference? 
> >
> >
> > Woops, one too many calls to `getNameWithPrefix`.
>
>
> I replaced `getMangler().getNameWithPrefix(SecName, Symbol, DL);` in `appendComdatSymbolForMinGW` with `SecName.append(Symbol.begin(), Symbol.end());`.  This removes the extra underscore but still doesn't associate a comdat with the section.  Is there anything else that I can try?


Reid fixed the underscore issue in https://reviews.llvm.org/rL335304, so you may wanna give that a shot.


Repository:
  rL LLVM

https://reviews.llvm.org/D48402