[PATCH] D48494: [doc] Show the git config for Windows to do line-endings correctly

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth added a comment.

I mostly agree with Zach.  In practice, setting core.autocrlf to `false` on Windows seems the most practical solution.

One could argue that test files that depend specifically on CR+LF or LF should be saved as binary files, in which case `true` might work, but I think it'd be hard to get to that point for relatively low value.  As I recall, we have tests where if the test file gets switched to the other scheme, the test passes and effectively gives us no feedback.

I like the idea of `input`, but I don't have enough experience with it to know if it would actually be practical.  It seems like a good idea for that to happen once on new files, but not on every commit that updates a file.


Repository:
  rL LLVM

https://reviews.llvm.org/D48494