[PATCH] D48332: [AArch64] Add custom lowering for v4i8 trunc store

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: test/CodeGen/AArch64/neon-truncStore-extLoad.ll:27
+; CHECK: xtn [[TMP2:(v[0-9]+)]].8b, [[TMP]].8h
+; CHECK: {{st1 { [[TMP2]].4h }[0]|str s[0-9]+}}, [x{{[0-9]+|sp}}]
+  %b = trunc <4 x i32> %a to <4 x i8>
----------------
zatrazz wrote:
> efriedma wrote:
> > zatrazz wrote:
> > > rengolin wrote:
> > > > efriedma wrote:
> > > > > Why does this CHECK line have two possible lowerings?
> > > > looks like it's a copy of the pattern around... weird...
> > > > 
> > > > What's the instruction actually generated?
> > > Indeed I used the previous function as example (truncStore.v4i32), and for current testing the instruction being generated is 'str'.
> > Please get rid of the "|" in all the patterns in this file.
> Right (for some reason I had in mind I already fixed it).
Still not fixed...?


https://reviews.llvm.org/D48332