[PATCH] D48476: Detecting leaked instructions with metadata and freeing the metadata to avoid use-after-free

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Thanks for the patch.

I like the idea of having a cheap leak check in debug builds. However, I don’t think we should add a mitigation for improper use of the API, because it can build up to code confusion/bloat over time. It becomes less clear what the API does/doesn’t support.

Could you please:

- Just keep the code conditional on !ndebug
- Update a diff with context (git diff -U10000)
- End sentences in comments with periods


Repository:
  rL LLVM

https://reviews.llvm.org/D48476