[PATCH] D48026: [ScopHelper] Provide support for recognising collective invariant loads
Siddharth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 22 04:59:43 PDT 2018
bollu added inline comments.
================
Comment at: lib/Analysis/ScopDetection.cpp:1155
+ while (1) {
+ unsigned int VariantSize = VariantLS.size(),
+ InvariantSize = InvariantLS.size();
----------------
consider `const unsigned int`? Also, I prefer a name like `CurrentVariantSize` and `CurrentInvariantSize`, since this indicates that the sizes will be changing soon after.
https://reviews.llvm.org/D48026
More information about the llvm-commits
mailing list