[PATCH] D48271: [llvm-readobj] Fix printing format

[Paul Semel via Phabricator via llvm-commits]

paulsemel added a comment.

In https://reviews.llvm.org/D48271#1140056, @dblaikie wrote:

> *looks at this a bit more closely*
>
> Ah, OK, so this is a string dumping mode - why is it dumping non-printable characters at all? (I assumed this was reimplementing/matching behavior of some existing tool (in the same way that llvm-objdump is meant to be like the binutils 'objdump' tool - I just assumed there was a 'readobj' tool out there somewhere, but googling around I don't immediately see anything like that)) more like the way the 'strings' tool would work?
>
> Or is this trying to match some existing/similar behavior elsewhere?


Actually, you were close, this is `readelf` from GNU Binutils (that's what my GSoC is about :) ).
This option exists in this tool, with the same name.
They are printing non-printable characters a little bit different, but I find this way better :)


Repository:
  rL LLVM

https://reviews.llvm.org/D48271