[PATCH] D48077: [LNT] Allow --use-perf=profile and --run-under to work together

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls accepted this revision.
kristof.beyls added a comment.
This revision is now accepted and ready to land.

It's clear from your description that the run_under _mutateCommandLine isn't a "private" function in the module as is, and therefore removing the under score makes sense to me.
Maybe it'd be better for the mutatePlan in perf.py to be implemented in a different way so that _mutateCommandLine really can be private in the run_under module.
I'm afraid I don't have enough experience here to know whether that would be a reasonable goal, implementable with reasonable effort.
I hope @MatzeB could share his opinion on this.

On writing a unit test for this - I also fear that @MatzeB may be the only one who's up to speed on the unit tests for the test-suite framework itself.

Despite all of that - I think it's reasonable to commit this patch as is to unbreak the breakage that was introduced by that past refactoring.


https://reviews.llvm.org/D48077