[PATCH] D48446: [ubsan] Add support for reporting diagnostics to a monitor process

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: lib/ubsan/ubsan_monitor.h:36
+/// that a UB report is available.
+extern "C" SANITIZER_INTERFACE_ATTRIBUTE void __ubsan_on_report(void);
+
----------------
vsk wrote:
> vitalybuka wrote:
> > I'd prefer interface consistent with similar one from TSAN:
> > __tsan_on_report(void *report) {
> >   __tsan_get_report_loc(report.....
> >   __tsan_get_report_loc_object_type(report.....
> > }
> > 
> > Also this will avoid having state set by RegisterUndefinedBehaviorReport
> Point taken, it would be a bit simpler this way. However, we can't make this change because it would break debuggability of code compiled with Xcode 9.
Does Xcode 9 works for tsan?


https://reviews.llvm.org/D48446