[PATCH] D48446: [ubsan] Add support for reporting diagnostics to a monitor process

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 21 17:31:31 PDT 2018


vitalybuka added inline comments.


================
Comment at: lib/ubsan/ubsan_monitor.h:36
+/// that a UB report is available.
+extern "C" SANITIZER_INTERFACE_ATTRIBUTE void __ubsan_on_report(void);
+
----------------
I'd prefer interface consistent with similar one from TSAN:
__tsan_on_report(void *report) {
  __tsan_get_report_loc(report.....
  __tsan_get_report_loc_object_type(report.....
}

Also this will avoid having state set by RegisterUndefinedBehaviorReport


https://reviews.llvm.org/D48446





More information about the llvm-commits mailing list