[PATCH] D45916: Enable MachineOutliner by default under -Oz for AArch64

[Jessica Paquette via Phabricator via llvm-commits]

paquette updated this revision to Diff 152375.
paquette added a comment.

Updated the patch so that it no longer causes issues for the AMDGPU target. The outliner is now only added to the pass pipeline if a target specifies that it supports it in its TargetOptions. After this, whether or not a target supports the outliner must be defined within a specific TargetMachine (similar to GlobalIsel).

It seems like although the outliner wasn't actually *doing* anything in the AMDGPU target, the verifier was running on the module after it was added, raising issues there.


https://reviews.llvm.org/D45916

Files:
  include/llvm/CodeGen/TargetInstrInfo.h
  include/llvm/Target/TargetMachine.h
  include/llvm/Target/TargetOptions.h
  lib/CodeGen/MachineOutliner.cpp
  lib/CodeGen/TargetPassConfig.cpp
  lib/Target/AArch64/AArch64InstrInfo.cpp
  lib/Target/AArch64/AArch64InstrInfo.h
  lib/Target/AArch64/AArch64TargetMachine.cpp
  lib/Target/X86/X86InstrInfo.h
  lib/Target/X86/X86TargetMachine.cpp
  test/CodeGen/AArch64/O3-pipeline.ll
  test/CodeGen/AArch64/arm64-memset-to-bzero.ll
  test/CodeGen/AArch64/arm64-opt-remarks-lazy-bfi.ll
  test/CodeGen/AArch64/cond-sel.ll
  test/CodeGen/AArch64/machine-outliner-calls.mir
  test/CodeGen/AArch64/machine-outliner-flags.ll
  test/CodeGen/AArch64/machine-outliner-noredzone.ll
  test/CodeGen/AArch64/machine-outliner-remarks.ll
  test/CodeGen/AArch64/machine-outliner-tail.ll
  test/CodeGen/AArch64/machine-outliner-thunk.ll
  test/CodeGen/AArch64/machine-outliner.ll
  test/CodeGen/AArch64/machine-outliner.mir
  test/CodeGen/AArch64/max-jump-table.ll
  test/CodeGen/X86/O3-pipeline.ll
  test/CodeGen/X86/cfi-inserter-check-order.ll
  test/CodeGen/X86/machine-outliner-debuginfo.ll
  test/CodeGen/X86/machine-outliner-disubprogram.ll
  test/CodeGen/X86/machine-outliner-noredzone.ll
  test/CodeGen/X86/machine-outliner-tailcalls.ll
  test/CodeGen/X86/machine-outliner.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45916.152375.patch
Type: text/x-patch
Size: 25709 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180621/660e970f/attachment.bin>