[PATCH] D48404: Don't modify LibFuncs in LTO

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 21 12:07:31 PDT 2018


tejohnson added a comment.

In https://reviews.llvm.org/D48404#1139705, @jgravelle-google wrote:

> Probably just IPO then. It's still not WebAssembly specific.


Please update the patch description.

> Is there a good place to put the testcase? I guess test/Other?

Better would be the appropriate subdirectory of test/Transforms. Although you should split your test - one for dead arg elim and one for arg promotion.

What happens without this patch - incorrect behavior or other missed optimization opportunities? Are we losing anything important by preventing the optimizations?


Repository:
  rL LLVM

https://reviews.llvm.org/D48404





More information about the llvm-commits mailing list