[PATCH] D48446: [ubsan] Add support for reporting diagnostics to a monitor process

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 21 12:00:44 PDT 2018


vsk added inline comments.


================
Comment at: lib/ubsan/ubsan_monitor.cc:53
+  InternalScopedString &Buf = CurrentUBR->Buffer;
+  char FirstChar = Buf.data()[0];
+  if (FirstChar >= 'a' && FirstChar <= 'z')
----------------
vitalybuka wrote:
> why do you need this?
This is a relatively noninvasive way of making sure the text of diagnostics can't begin with a lowercase letter. I'll add a comment.


https://reviews.llvm.org/D48446





More information about the llvm-commits mailing list