[PATCH] D48128: [ARM] Parallel DSP IR Pass

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/Target/ARM/ARMParallelDSP.cpp:259
+    LLVM_DEBUG(dbgs() << "OK: loads are consecutive.\n");
+    return true;
+  }
----------------
Do you need to check that the memory isn't modified between the two loads?


================
Comment at: lib/Target/ARM/ARMParallelDSP.cpp:540
+                                    AccTy->getPointerTo(AddrSpace));
+  *VecLd = IRB.CreateLoad(Acc->getType(), VecPtr);
+  (*VecLd)->setAlignment(Alignment);
----------------
CreateAlignedLoad?


https://reviews.llvm.org/D48128