[PATCH] D48398: [test-suite] Set the language standard for SPEC benchmarks that do not compile using the newest.

[Evandro Menezes via Phabricator via llvm-commits]

evandro added inline comments.


================
Comment at: test-suite/trunk/External/SPEC/CINT2006/473.astar/CMakeLists.txt:1
+list(APPEND CPPFLAGS -std=c++98)
+
----------------
Meinersbur wrote:
> evandro wrote:
> > Should this be `c++03` instead?
> ` -std=gnu++98` was the setting before changed in rL320250. It does not rely on gnu extensions so I picked `-std=c++98`. 
> 
> What is your your argument to use ` -std=c++03` instead?
It's what some internal scripts of ours use. Unfortunately, none of us could recall why C++03 was chosen.  Digging the SPEC CPU2006 distro, it seems that it was released with example configuration files supporting GCC versions like 4.1 and 4.3, which only supported C++98.  So, I agree with your choice.


Repository:
  rL LLVM

https://reviews.llvm.org/D48398