[PATCH] D48102: Improve handling of COPY instructions with identical value numbers

[Tim Renouf via Phabricator via llvm-commits]

tpr added inline comments.


================
Comment at: lib/CodeGen/RegisterCoalescer.cpp:2873
+          LiveRange::iterator T = S.find(Def);
+          assert(Id != S.end() && T != S.end() && T->valno == Id->valno);
+#endif
----------------
tpr wrote:
> kparzysz wrote:
> > tpr wrote:
> > > I now have a test case that hits this assert. I will investigate further.
> > It could be because of a basic block boundary between Def and OtherDef.  You can probably delete this code under #ifndef NDEBUG.
> We don't want to test this in the case that there were no end points to extend to. So I put this round the block of code inside the #ifndef:
> 
> 
> ```
>           if (!EndPoints.empty()) {
> ```
Even with that change, I've now got a different test case that hits this assert. I'll investigate and see what is going on.


Repository:
  rL LLVM

https://reviews.llvm.org/D48102