[PATCH] D45968: StackSlotColoring: Decide colors per stack ID

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/CodeGen/StackSlotColoring.cpp:303
 
+  assert(MFI->getStackID(Color) == MFI->getStackID(FI));
+
----------------
tpr wrote:
> As you pointed out, my review D48416 tries to fix the same problems.
> 
> Color is now per-StackID, right? But the color is used as the new frame index and written back to the operands. So how does this assert, or the assert at AMDGPU/SIFrameLowering.cpp:694, or anything that uses the new frame index (the color) to index into MFI->StackObjects, work now? 
IIRC I tried something similar to your approach and it didn't work. 

If I remember how this works, the color can only be determined from the set of used frame indexes already (which are now tracked disjointly)


https://reviews.llvm.org/D45968