[llvm] r335202 - [RISC-V] Fix a test case to not include label names as those aren't

Alex Bradbury via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 21 05:55:35 PDT 2018


On 21 June 2018 at 06:42, Chandler Carruth via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: chandlerc
> Date: Wed Jun 20 22:42:05 2018
> New Revision: 335202
>
> URL: http://llvm.org/viewvc/llvm-project?rev=335202&view=rev
> Log:
> [RISC-V] Fix a test case to not include label names as those aren't
> stable in non-asserts builds. This fixes a test failure in release
> config.

Thanks for the fix, the failure was triggered by a change in label
names in r335183.

CHECK lines including label names are frequently generated by
update_llc_test_checks.py. It looks like .L* # %somename' is checked
in 157 files within test/CodeGen/*.

$ git grep -l -i "\.L.*# %" test/CodeGen | wc -l
157

These don't currently pose a problem for running the test suite in
release builds, but arguably it makes the tests more brittle than
necessary. Should we be stripping these comments in
update_llc_test_checks.py?


More information about the llvm-commits mailing list