[PATCH] D47872: [AArch64] Clean up LSE directive tests

Bernard Ogden via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 21 05:15:37 PDT 2018


bogden added a comment.

In https://reviews.llvm.org/D47872#1124809, @fhahn wrote:

> It would be great if you could add the test with  `.cpu generic+v8.1-a` as a negative test in https://reviews.llvm.org/D47873


Coming soon...



================
Comment at: test/MC/AArch64/directive-arch.s:11
 
+	.arch armv8.1-a+lse
+        casa  w5, w7, [x20]
----------------
fhahn wrote:
> armv8.1-a does imply LSE, right? So would it be better to test `.arch armv8-a+lse`  and `.arch armv8.1-a`?
Good catch. Fixed patch coming.


Repository:
  rL LLVM

https://reviews.llvm.org/D47872





More information about the llvm-commits mailing list