[PATCH] D48128: [ARM] Parallel DSP IR Pass

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: lib/Target/ARM/ARMParallelDSP.cpp:222
+
+    if (Inst0->getOpcode() == Inst1->getOpcode()) {
+      LLVM_DEBUG(dbgs() << "OK: opcodes match!\n");
----------------
Is it worth using Inst0->isSameOperationAs(Inst1) here? I'm wondering whether we need to consider varying flags.


================
Comment at: lib/Target/ARM/ARMParallelDSP.cpp:393
+    const Type *Ty = Phi.getType();
+    if (!Ty->isIntegerTy())
+      continue;
----------------
You can combine these two type checks by using Ty->isIntegerTy(32).


================
Comment at: lib/Target/ARM/ARMParallelDSP.cpp:543
+  *VecLd = IRB.CreateLoad(Acc->getType(), VecPtr);
+  (*VecLd)->setAlignment(4);
+}
----------------
Isn't this supposed to match the alignment of the underlying memory type? So 2 for i16.


https://reviews.llvm.org/D48128