[PATCH] D48397: [dsymutil] Force mmap'ing of binaries

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 21 01:50:24 PDT 2018


JDevlieghere added a comment.

In https://reviews.llvm.org/D48397#1138455, @friss wrote:

> If you have a local test case with an archive that triggers the malloc behavior, can you run an Asanified dsymutil on it with your patch applied? I'd like to make sure that nothing in dsymutil is going to access one past the end of the file.


Done, no invalid memory access detected. This sounds right to me, as the MemoryBuffer sets the size of the buffer and libObject does a relatively good job at bounds checking.


Repository:
  rL LLVM

https://reviews.llvm.org/D48397





More information about the llvm-commits mailing list