[PATCH] D48338: [SCEV] Improve zext(A /u B) and zext(A % B)

Tim Shen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 20 18:52:01 PDT 2018


timshen marked an inline comment as done.
timshen added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:12185
+
+  const auto MatchURem = [&](const SCEV *B) {
+    // (SomeExpr + (-(SomeExpr / B) * B)).
----------------
sanjoy wrote:
> Might be clearer to call this `MatchURemWithDivisor` and call the argument `Divisor` or `D`.
I'll keep the variable name "B", as it's consistent throughout the surrounding comments


https://reviews.llvm.org/D48338





More information about the llvm-commits mailing list