[PATCH] D48332: [AArch64] Add custom lowering for v4i8 trunc store
Renato Golin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 20 13:11:53 PDT 2018
rengolin added inline comments.
================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:2695
+ StoreSDNode *StoreNode = cast<StoreSDNode>(Op);
+ assert (StoreNode);
+
----------------
Last nit: we usually add a text at the end, in this case, something saying this is not the droids we're looking for... ex:
assert(StoreNode && "Can only custom lower store nodes");
assert(VT.isVector() && "Can only custom lower vector store types");
https://reviews.llvm.org/D48332
More information about the llvm-commits
mailing list