[PATCH] D48372: [MemorySSAUpdater] Remove deleted trivial Phis from active workset

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 20 11:21:23 PDT 2018


efriedma added inline comments.


================
Comment at: lib/Analysis/MemorySSAUpdater.cpp:208
   if (Phi) {
+    InsertedPHIs.remove(Phi);
     Phi->replaceAllUsesWith(Same);
----------------
remove on a SmallSetVector is linear time, which might be a problem here.


https://reviews.llvm.org/D48372





More information about the llvm-commits mailing list