[PATCH] D48277: [DebugInfo] Keep DBG_VALUE undef in LiveDebugVariables

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/CodeGen/LiveDebugVariables.cpp:227
 
   /// getLocationNo - Return the location number that matches Loc.
+  ///
----------------
Can you delete the `getLocationNo - ` part?


================
Comment at: lib/CodeGen/LiveDebugVariables.cpp:992
+      // Undef values always have location number UndefLocNo, so don't change
+      // locNo in that case. See getLocationNo().
+      if (!v.isUndef() && v.locNo() > OldLocNo)
----------------
I think with the comment this is fine.


https://reviews.llvm.org/D48277