[PATCH] D48364: [DAG] Don't map a TableId to itself in the ReplacedValues map

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 20 08:27:21 PDT 2018


niravd accepted this revision.
niravd added a comment.
This revision is now accepted and ready to land.

LGTM.  Thanks!



================
Comment at: lib/CodeGen/SelectionDAG/LegalizeTypes.cpp:658
+      ReplacedValues[FromId] = ToId;
     DAG.ReplaceAllUsesOfValueWith(From, To);
 
----------------
bjope wrote:
> I think we still need to do this replacement even if FromId == ToId, since From.getNode() != To.getNode(), right?
Yes. 


Repository:
  rL LLVM

https://reviews.llvm.org/D48364





More information about the llvm-commits mailing list