[PATCH] D48102: Improve handling of COPY instructions with identical value numbers
Tim Renouf via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 20 06:05:35 PDT 2018
tpr added inline comments.
================
Comment at: lib/CodeGen/RegisterCoalescer.cpp:2873
+ LiveRange::iterator T = S.find(Def);
+ assert(Id != S.end() && T != S.end() && T->valno == Id->valno);
+#endif
----------------
kparzysz wrote:
> tpr wrote:
> > I now have a test case that hits this assert. I will investigate further.
> It could be because of a basic block boundary between Def and OtherDef. You can probably delete this code under #ifndef NDEBUG.
We don't want to test this in the case that there were no end points to extend to. So I put this round the block of code inside the #ifndef:
```
if (!EndPoints.empty()) {
```
Repository:
rL LLVM
https://reviews.llvm.org/D48102
More information about the llvm-commits
mailing list