[PATCH] D48323: Derive GEP index type from Data Layout (cont)

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added a comment.

AFAIK BasicAA assumes that all GEP indices have a common type. So "normalization" is for example needed before passes like GVN that uses MemoryDependenceResults, that is using BasicAA. Or maybe that is a bug in BasicAA?

Passes like InstCombine might skip doing rewrites in some basic blocks (e.g. if they are unreachable from entry). So I do not think that we can't rely on InstCombine doing a normalization for all GEP:s in the function.
So are we moving towards always using the "normalized" type from scratch (in all passes) when creating a GEP, or what is the plan here?


Repository:
  rL LLVM

https://reviews.llvm.org/D48323