[PATCH] D48229: [NFC][SCEV] Add tests related to bit masking (PR37793)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In https://reviews.llvm.org/D48229#1137346, @mkazantsev wrote:

> LGTM


Thank you for the review!



================
Comment at: lib/Transforms/InstCombine/InstCombineShifts.cpp:625
 
-    // Be careful about hiding shl instructions behind bit masks. They are used
-    // to represent multiplies by a constant, and it is important that simple
-    // arithmetic expressions are still recognizable by scalar evolution.
-    // The inexact versions are deferred to DAGCombine, so we don't hide shl
-    // behind a bit mask.
+    // FIXME: we do not yet transform non-exact lshr's. The backend (DAGCombine)
+    // needs a few fixes for the rotate pattern recognition first.
----------------
This obviously should be `// FIXME: we do not yet transform non-exact shr's. The backend (DAGCombine)`
Will fix before commit.


Repository:
  rL LLVM

https://reviews.llvm.org/D48229