[PATCH] D48240: Try again to implement a FIFO task queue

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 19 19:03:22 PDT 2018


zturner updated this revision to Diff 152013.
zturner added a comment.

Updated based on suggestions from Chandler.  I don't have the `LLVM_ENABLE_THREADS=0` case working yet, but wanted to make sure this is generally what you had in mind.

I also removed the `wait()` function entirely, as it's a little more difficult to implement now.  I can't just wait on the `ThreadPool` because there could in theory be other work on the thread pool, so waiting on the task queue is not the same as waiting on the thread pool.  I don't have an immediate need for this functionality, so unless someone else does, yagni.


https://reviews.llvm.org/D48240

Files:
  llvm/include/llvm/Support/TaskQueue.h
  llvm/lib/Support/CMakeLists.txt
  llvm/lib/Support/TaskQueue.cpp
  llvm/unittests/Support/CMakeLists.txt
  llvm/unittests/Support/TaskQueueTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48240.152013.patch
Type: text/x-patch
Size: 10935 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180620/f623af0c/attachment.bin>


More information about the llvm-commits mailing list