[PATCH] D47874: [SCEVExp] Advance found insertion point until we find a non-dbg instruction.
Vedant Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 19 16:49:09 PDT 2018
vsk added inline comments.
================
Comment at: include/llvm/IR/BasicBlock.h:440
+ It++;
+ return It;
+}
----------------
fhahn wrote:
> vsk wrote:
> > I think this should skip llvm.ptr.annotation, llvm.var.annotation, etc. as well.
> >
> > Stepping back a bit, I shouldn't have suggested adding a 'skip meta instruction' API as a part of your SCEVExpander bug fix. IMO it would be cleaner to split the new API out, add a unit test, and incorporate some light refactoring along with it.
> >
> > Would you mind if I started a separate review to add this API? I had a patch for this prepped before I went out-of-office, but didn't have the time to start a review then. I'd be happy to take a stab at this.
> > Would you mind if I started a separate review to add this API? I had a patch for this prepped before I went out-of-office, but didn't have the time to start a review then. I'd be happy to take a stab at this.
>
> Not at all, that would be great. I will probably only be able to pick this patch up again in a couple of days.
Great, 'rL335083: [IR] Introduce helpers to skip debug instructions (NFC)' has landed, hope that helps.
https://reviews.llvm.org/D47874
More information about the llvm-commits
mailing list